[GEODE-9109] The local filter (CQ/Interest) computation code seems to be not needed

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.15.0
• Fix Version/s: 1.15.0
• Component/s: transactions
• Labels: pull-request-available
• Assignee: Eric Shu
• Reporter: Anilkumar Gingade
• Created: 31/Mar/21 22:11
• Updated: 22/Jun/22 20:45
• Resolved: 04/May/21 16:09

Description

In TxCallbackEventFactoryImpl.createCallbackEvent() there is logic which looks to see if filters (CQ/Interests) needs to be computed after receiving the TX commit message from remote. Since with GEODE-8926 the computation for remote nodes happen in primary only the logic here looks like unnecessary.

boolean computeFilterInfo = false;
      if (filterRoutingInfo != null) {
        localRouting = filterRoutingInfo.getLocalFilterInfo();
        if (localRouting != null) {
          // routing was computed in this VM but may need to perform local interest processing
          computeFilterInfo = !filterRoutingInfo.hasLocalInterestBeenComputed()
              && !localRouting.filterProcessedLocally;
        } else {
          // routing was computed elsewhere and is in the "remote" routing table
          localRouting = filterRoutingInfo.getFilterInfo(internalRegion.getMyId());
        }
        if (localRouting != null) {
          if (!computeFilterInfo) {
            retVal.setLocalFilterInfo(localRouting);
          }
        }
      }

Check with computeFilterInfo.

Issue Links

• links to: GitHub Pull Request #6418