[GEODE-8955] WAN location service uses DistributedLocatorId.toString() to represent a locator - ASF JIRA

Attach files

Attach Screenshot

Voters

Watch issue

Watchers

Create sub-task

Link

Clone

Update Comment Author

Replace String in Comment

Update Comment Visibility

Delete Comments

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: None
Fix Version/s: 1.15.0
Component/s: wan
Labels:
- pull-request-available

Description

This code in LocatorHelper, and probably code in other parts of the WAN location service, uses DistributionLocatorId.toString() to track whether other locators have the WAN location service available. It should use the DistributionLocatorId.marshal() method instead. We should never use the toString() representation of an object in this way as it may change over time.

private static void addServerLocator(Integer distributedSystemId,
    LocatorMembershipListener locatorListener, DistributionLocatorId locator) {
  ConcurrentHashMap<Integer, Set<String>> allServerLocatorsInfo =
      (ConcurrentHashMap<Integer, Set<String>>) locatorListener.getAllServerLocatorsInfo();

  Set<String> locatorsSet = new CopyOnWriteHashSet<String>();
  locatorsSet.add(locator.toString());
  Set<String> existingValue = allServerLocatorsInfo.putIfAbsent(distributedSystemId, locatorsSet);
  if (existingValue != null) {
    if (!existingValue.contains(locator.toString())) {
      existingValue.add(locator.toString());
    }
  }
}