[GEODE-8955] WAN location service uses DistributedLocatorId.toString() to represent a locator

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Fix Version/s: 1.15.0
• Component/s: wan
• Labels: pull-request-available
• Assignee: Mario Kevo
• Reporter: Bruce J Schuchardt
• Created: 19/Feb/21 16:40
• Updated: 22/Jun/22 20:45
• Resolved: 29/Mar/21 05:38

Description

This code in LocatorHelper, and probably code in other parts of the WAN location service, uses DistributionLocatorId.toString() to track whether other locators have the WAN location service available.  It should use the DistributionLocatorId.marshal() method instead.  We should never use the toString() representation of an object in this way as it may change over time.

 

private static void addServerLocator(Integer distributedSystemId,
    LocatorMembershipListener locatorListener, DistributionLocatorId locator) {
  ConcurrentHashMap<Integer, Set<String>> allServerLocatorsInfo =
      (ConcurrentHashMap<Integer, Set<String>>) locatorListener.getAllServerLocatorsInfo();

  Set<String> locatorsSet = new CopyOnWriteHashSet<String>();
  locatorsSet.add(locator.toString());
  Set<String> existingValue = allServerLocatorsInfo.putIfAbsent(distributedSystemId, locatorsSet);
  if (existingValue != null) {
    if (!existingValue.contains(locator.toString())) {
      existingValue.add(locator.toString());
    }
  }
}

Issue Links

• causes: GEODE-10127 Incorrect locator hostname used in remote locator connections
• links to: GitHub Pull Request #6045