[GEODE-8894] Allow individual deltas to trigger bucket size recalculation

• Type: New Feature
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.14.0
• Fix Version/s: 1.14.0, 1.15.0
• Component/s: core, serialization
• Labels: blocks-1.14.0​ pull-request-available
• Assignee: Ray Ingles
• Reporter: Ray Ingles
• Created: 29/Jan/21 21:39
• Updated: 03/Sep/21 02:23
• Resolved: 23/Feb/21 18:25

Description

The Redis subsystem uses Deltas heavily, but by default deltas do not trigger an update to the size of their buckets. This leads to incorrect memory usage accounting over the long term, especially with the use of Redis commands like "APPEND".

It is possible to set the system property "DELTAS_RECALCULATE_SIZE", but this is a global value that would affect the processing of all deltas, including non-Redis operations.

Instead, we will add a new default method to the Delta interface, that can be overridden by individual Delta implementations (such as Redis). This will trigger the same behavior as DELTAS_RECALCULATE_SIZE, but on a per-delta basis. Thus, other Geode operations will not force bucket size recalculations unless the global property is set, but Redis statistics will be correct.

Other types of delta operations may find this useful in the future.

Issue Links

• links to: GitHub Pull Request #5978