[GEODE-8815] Cache could close with uncaught exception

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.2, 1.13.2, 1.14.0
• Labels: pull-request-available
• Assignee: Jianxia Chen
• Reporter: Jianxia Chen
• Created: 07/Jan/21 01:29
• Updated: 26/Mar/21 22:24
• Resolved: 09/Jan/21 02:10

Description

In GemFireCacheImpl.initialize(), it is possible that an uncaught exception is not logged and close the cache.

     try {
      if (!isClient) {
        applyJarAndXmlFromClusterConfig();
      }
      initializeDeclarativeCache();
      completedCacheXml = true;
    } catch (RuntimeException e) {
      logger.error("Cache initialization for " + this.toString() + " failed because:", e);
      throw e;
    } finally {
      if (!completedCacheXml) {
        // so initializeDeclarativeCache threw an exception
        try {
          close();
        } catch (Throwable ignore) {
          // I don't want init to throw an exception that came from the close.
          // I want it to throw the original exception that came from initializeDeclarativeCache.
        }
        configurationResponse = null;
      }

Issue Links

• links to: GitHub Pull Request #5882