[GEODE-8651] MsgReader's readHeader and readMessage should be synchronized

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.1, 1.13.1, 1.14.0
• Component/s: membership
• Labels: GeodeOperationAPI pull-request-available
• Assignee: Xiaojian Zhou
• Reporter: Xiaojian Zhou
• Created: 23/Oct/20 22:15
• Updated: 18/Nov/20 00:37
• Resolved: 28/Oct/20 00:06

Description

When the connection reads direct ack, there're 2 steps: readHeader and readMessage.
Another thread could jump in between to clear the buffer.

The another thread is doing notifyHandShakeWaiter's second call, which could clear the buffer.

Issue Links

• fixes: GEODE-8652 member hung in Connection.notifyHandshakeWaiter() during disconnect waiting for a lock held by another thread in Connection.readAck()
• links to: GitHub Pull Request #5665