Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-8103

Rename SniSocketFactory to SniProxySocketFactory for consistency.

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 1.13.0, 1.14.0
    • Fix Version/s: 1.13.0, 1.14.0
    • Component/s: client/server
    • Labels:
      None

      Description

      The class SniSocketFactory should be renamed SniProxySocketFactory. The class in question produces objects of type SniProxySocket. An "SNI socket" isn’t a thing but an SNI proxy is a thing. The factory class that produces proxy socket factories (yes a meta factory) ProxySocketFactories uses the “ProxySocket” name as well. It fells very inconsistent with all the other classes that make up with API for SniSocketFactory to not have a proxy in it and be called SniProxySocketFactory.

        Attachments

          Activity

            People

            • Assignee:
              Unassigned
              Reporter:
              jbarrett Jacob Barrett
            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: