[GEODE-7820] Avoid Unnecessary toArray Invocations

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.0, 1.13.0
• Component/s: membership
• Labels: GeodeCommons
• Assignee: Ernest Burghardt
• Reporter: Juan Ramos
• Created: 27/Feb/20 12:45
• Updated: 30/Mar/20 23:34
• Resolved: 28/Feb/20 11:48

Description

The DistributionMessage class receives the recipients as a Collection object (which is always a Set after inspecting the calls) but it internally transforms the collection into an array [], this transformation appears to be useless as we end up converting the array [] into a List across several parts of the code afterwards when we need to do something with it.
Using one of our internal testing scenarios and a java profiler we detected that, under the current develop branch, we spend ~8 seconds more than when using Geode 1.10 just by executing this toArray transformation (screenshot attached), which can be completely avoided.

Issue Links

• links to: GitHub Pull Request #4741