[GEODE-7533] System Properties catalina.home and catalina.base are cleared during webapp reloads when using HTTP Session Management Module

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.12.0
• Component/s: http session
• Assignee: Ernest Burghardt
• Reporter: Charles Smith
• Created: 04/Dec/19 04:36
• Updated: 30/Mar/20 23:32
• Resolved: 05/Feb/20 20:41

Description

I noticed when using the HTTP Session Management Module for AppServers that my tomcat environment would act oddly when my webapp was reloaded. I tracked this down to the fact that catalina.home and catalina.base system properties were missing when the webapp reloaded.

 

A quick search of the Geode code base found a couple of unexplainable lines in:

geode-http-service/src/main/java/org/apache/geode/internal/cache/InternalHttpService.java

in the close() method there are 2 calls to System.clearProperty() which essentially clear catalina.home and catalina.base.

 

I am guessing that these lines exist from a previous state of this InternalHttpService when it was perhaps using an embedded Tomcat instance. Now the class appears to be implemented using Jetty and there are no other references to the catalina properties than the lines that clear them.

 

This is likely also causing issues with the HTTP Session Management Module for Tomcat. I was a least able to workaround this issue by disabling the embedded HTTP server in the filter properties that configured the HTTP Session Management Module.

 

Probably these 2 lines should just be removed from the InternalHttpService class...

Issue Links

• links to: GitHub Pull Request #4414