[GEODE-7182] TcpSslConn.cpp does not compile with gcc 8.3

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.10.0
• Component/s: native client
• Assignee: Unassigned
• Reporter: Owen Nichols
• Created: 10/Sep/19 17:27
• Updated: 22/Nov/19 23:52
• Resolved: 10/Sep/19 23:24

Description

I tried to build native client using:
$ gcc --version
gcc (Debian 8.3.0-6) 8.3.0
$ cmake --version
cmake version 3.13.4
$ openssl version
OpenSSL 1.1.1c  28 May 2019

and got:
cppcache/src/TcpSslConn.cpp:60: error: catching polymorphic type 'class std::exception' by value

The BUILDING.md states that I should be able to use "GCC 5 or newer".

Fixing the code to resolve this warning is a straightforward 1-character change and a good idea anyway even if the official pipelines continue to compile using older compilers that don't generate this warning yet.

Issue Links

• links to: GitHub Pull Request #515