[GEODE-6950] Locator can't start if a lot of clients already started

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.7.0, 1.8.0, 1.9.0, 1.10.0, 1.11.0, 1.12.0
• Fix Version/s: 1.14.0
• Component/s: core, membership
• Labels: pull-request-available
• Assignee: Bruce J Schuchardt
• Reporter: Eugene Nedzvetsky
• Created: 09/Jul/19 07:27
• Updated: 03/Sep/21 02:24
• Resolved: 06/Aug/20 22:27

Description

Locator can't start if a few hundred clients already started.
Steps to reproduce:
1. Start Locator
2. Start 300 Geode clients
3. Stop Locator
4. Start Locator again
Observe 100% CPU load and after some time Locator app crashes with timeout exceptions in the log.

The problem is in the method org.apache.geode.distributed.internal.InternalLocator.PrimaryHandler#processRequest
handlerMapping doesn't have handlers for LocatorListRequest and ClientConnectionRequest requests on Locator startup and in this case work code part with condition 'if(giveup == 0)'(InternalLocator:1185)

Pause Thread.sleep(1000) works only on the first iteration and after that giveup>0 and CPU just spends resources on cycle execution without any pauses.

Call Thread.sleep(1000)  should be after if(giveup>0) condition block. It will be called on each iteration in this case.

 

Issue Links

• links to: GitHub Pull Request #5422