[GEODE-6875] Remove unused code and deprecated/internal API usages in Tomcat session state module

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.10.0
• Component/s: http session
• Labels: GeodeCommons
• Assignee: Juan Ramos
• Reporter: Ryan McMahon
• Created: 17/Jun/19 15:53
• Updated: 26/Sep/19 18:02
• Resolved: 22/Jul/19 18:33

Description

The Tomcat session state module has significant amounts of dead code as well as deprecated/internal API usages.  We should make a pass through and clean this up.  These reports can also be generated via IntelliJ's built-in report tooling if it is more convenient.

• Go through the following report and delete all fully unused code

https://drive.google.com/open?id=1W1bbKw2JE7CvcDajE9MyQhpCTSR_IeGw

• Go through the following report and replace deprecated API usage with correct API:

https://drive.google.com/open?id=1b7RvM9Dbf85HsFLqVF7r5xYTEn5PbHOm

• Identify areas we use internal Geode APIs and remove the usages if possible, or determine why we cannot use them

https://docs.google.com/document/d/1pvYIj0yvjy6xqRPzLEqE_Mp4t8Lj5yK45DbAoup-QZg/edit?usp=sharing

Issue Links

• is a child of: GEODE-6864 Epic For Session State Caching
• links to: GitHub Pull Request #3813