[GEODE-6691] Callers of org.apache.geode.internal.security.SecurityService.authorize(Resource, Operation, String, String) could be optimized by passing the key Object instead of always converting it to a String

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.10.0
• Component/s: client/server
• Labels: performance
• Assignee: Mario Ivanac
• Reporter: Darrel Schneider
• Created: 22/Apr/19 19:10
• Updated: 26/Sep/19 18:04
• Resolved: 17/Jun/19 17:17

Description

Lots of client/server messages call org.apache.geode.internal.security.SecurityService.authorize(Resource, Operation, String, String).

The last argument is called with "key.toString()". When the security service is the default legacy one (which does no security) then this conversion of the key Object to a String is not needed.

This method could be changed to have its last parameter be an Object and then only in theIntegratedSecurityService do we need to call "toString()".

Issue Links

• links to: GitHub Pull Request #3711