[GEODE-5984] Address LGTM recommendations

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.8.0
• Labels: pull-request-available
• Assignee: Bruce J Schuchardt
• Reporter: Bruce J Schuchardt
• Created: 05/Nov/18 17:50
• Updated: 06/Nov/18 17:33
• Resolved: 06/Nov/18 17:18

Description

There is a list of 87 minor "recommendations" from the LooksGoodToMe CI integration report for 2b4313a:

Implicit conversion from Array to String.
Avoid automated semicolon insertion (97% of all statements in the enclosing function have an explicit semicolon).
@param for phantom parameters
Missing spaces in concatenated string literals

Others are in javascript files used by geode-book and Pulse.

https://lgtm.com/projects/g/apache/incubator-geode/alerts/?mode=list&severity=recommendation

Issue Links

• links to: GitHub Pull Request #2780