[GEODE-5725] Many WAN DUnit tests with off-heap enabled aren't actually exercising off-heap

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.8.0
• Component/s: offheap, wan
• Labels: pull-request-available
• Assignee: Ryan McMahon
• Reporter: Ryan McMahon
• Created: 11/Sep/18 17:37
• Updated: 18/Sep/18 18:44
• Resolved: 13/Sep/18 19:46

Description

Many of the WAN DUnit tests are run with both off-heap disabled and enabled. However, there is an optimization in the off-heap implementation where if the entry value is less than 8-bytes, off-heap is bypassed and the value is put on the heap. This is due to the value being equal to or less than the size of the off-heap address that would have been used. It is therefore pointless to use off-heap if the value itself is less than the size of the address.

In many WAN tests we are using longs as values, which will bypass off-heap in this way. However, it is expected that off-heap is being exercised. We should instead use another data type (strings) as values to be sure that the off-heap feature is actually being exercised.

Issue Links

• links to: GitHub Pull Request #2459