[GEODE-5650] Improve ClusterStartupRule tear down

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: tests
• Labels: pull-request-available
• Assignee: Unassigned
• Reporter: Sai Boorlagadda
• Created: 28/Aug/18 18:28
• Updated: 28/Aug/18 22:58
• Resolved: 28/Aug/18 19:54

Description

in CSRule teardown if we close suspect buffer before closing cache can cause some background threads (eg: client pool) to keep sending events and log exceptions (if any) could result in the next test to fail for suspects. So close the suspect buffer after closing cache in all VMs.

  protected void after() {
    try {
      DUnitLauncher.closeAndCheckForSuspects();
    } finally {
      MemberStarterRule.disconnectDSIfAny();

      // stop all the members in the order of clients, servers and locators
      List<VMProvider> vms = new ArrayList<>();
      vms.addAll(
          occupiedVMs.values().stream().filter(x -> x.isClient()).collect(Collectors.toSet()));
      vms.addAll(
          occupiedVMs.values().stream().filter(x -> x.isServer()).collect(Collectors.toSet()));
      vms.addAll(
          occupiedVMs.values().stream().filter(x -> x.isLocator()).collect(Collectors.toSet()));
      vms.forEach(x -> x.stop());

      // delete any file under root dir
      Arrays.stream(getWorkingDirRoot().listFiles()).filter(File::isFile)
          .forEach(FileUtils::deleteQuietly);

      restoreSystemProperties.after();
    }
  }

Issue Links

• links to: GitHub Pull Request #2392