[GEODE-5639] Replace usage of CatchException with AssertJ and remove CatchException dependency

• Type: Wish
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: build, tests
• Labels: pull-request-available
• Assignee: Kirk Lund
• Reporter: Kirk Lund
• Created: 27/Aug/18 17:04
• Updated: 03/Oct/18 21:37
• Resolved: 28/Aug/18 23:02

Description

We have a small number of tests using com.googlecode.catchexception.CatchException. This project isn't very active and AssertJ provides better support for testing expected exceptions and throwables. Most Geode developers are already using AssertJ for expected exceptions.

The tests using CatchException should be updated to instead use AssertJ and then remove our testing dependency on CatchException.

The recommended ways of handling expected exception testing would then involve using following AssertJ APIs:

1) Basic assertion about an expected exception

Use: org.assertj.core.api.Assertions.assertThatThrownBy

Example from JdbcWriterTest:

    assertThatThrownBy(() -> writer.beforeUpdate(entryEvent))
        .isInstanceOf(IllegalArgumentException.class);

2) Complex assertion about an expected exception (potentially with many nested causes with messages that we want to validate as well)

Use: org.assertj.core.api.Assertions.catchThrowable

Example from DeltaPropagationFailureRegressionTest:

    Throwable thrown = server1.invoke(() -> catchThrowable(() -> putDelta(FROM_DELTA)));

    assertThat(thrown).isInstanceOf(DeltaSerializationException.class)
        .hasMessageContaining("deserializing delta bytes").hasCauseInstanceOf(EOFException.class);

3) Simple assertion that an invocation should not thrown (probably used in a regression test)

Use: org.assertj.core.api.Assertions.assertThatCode

Example from RegisterInterestDistributedTest:

    assertThatCode(() -> clientCache.readyForEvents()).doesNotThrowAnyException();

Issue Links

• links to: GitHub Pull Request #2387