[GEODE-5630] Some tests using await should use until instead of untilAsserted

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: tests
• Labels: pull-request-available
• Assignee: Kirk Lund
• Reporter: Kirk Lund
• Created: 23/Aug/18 20:28
• Updated: 03/Oct/18 21:37
• Resolved: 27/Aug/18 17:00

Description

Awaitility was upgraded for GEODE-5593 and most or all of the await()...until() calls were changed to await()...untilAsserted(). One or more of these that are now incorrect.

BucketCreationCrashCompletesRegressionTest line 173 is now:

      await().atMost(2, MINUTES).untilAsserted(() -> {
        hasBucketOwners(partitionedRegion, bucketId);
      });

But hasBucketOwners returns a boolean and does not perform any assertions.

I'll fix this test and then review every other test that was changed to use untilAsserted.

Issue Links

• links to: GitHub Pull Request #2371
• links to: GitHub Pull Request #2378