[GEODE-5420] Protect events in HAContainer from being removed prematurely

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.7.0
• Component/s: client queues
• Labels: pull-request-available
• Assignee: Ryan McMahon
• Reporter: Ryan McMahon
• Created: 11/Jul/18 22:00
• Updated: 03/Oct/18 21:38
• Resolved: 01/Aug/18 22:43

Description

This can occur when:

1) Events are added to queuedEvents during message dispatcher initialization
2) Events are added to giiQueue while serving initial image to peer

We have seen this issue when QRM messages are being processed after becoming primary. This causes the event to be removed prematurely from the HAContainer, and then the wrapper is in a bad state (null client update message) when we try to replace the event.

Issue Links

• Blocked: GEODE-5344 race condition between Queue Removal Thread and Message Dispatcher can prevent dispatching to client
• links to: GitHub Pull Request #2131
• links to: GitHub Pull Request #2195
• links to: GitHub Pull Request #2204