[GEODE-4885] DistributedRestoreSystemPropertiesTest is failing

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.6.0
• Component/s: tests
• Labels: pull-request-available
• Assignee: Kirk Lund
• Reporter: Jens Deppe
• Created: 18/Mar/18 21:43
• Updated: 02/May/18 18:21
• Resolved: 20/Mar/18 19:22

Description

This test is supposedly checking for any DUnitTest that inadvertently runs under the test gradle task or, more specifically, is categorized as a UnitTest.

Unfortunately, due to the way that Junit determines what category a test is in (by creating an instance of the class), it will also invoke any static declarations. It also triggers parameterized values. The result is that some DistributedTests actually end up launching DUnit VMs even though the actual tests don't run. Depending on test ordering this can lead to DistributedRestoreSystemPropertiesTest failing intermittently.

By examining the test report, it appears that the following DUnit tests are triggering this problem:

org.apache.geode.management.internal.cli.commands.ShowLogCommandDUnitTest
org.apache.geode.internal.cache.rollingupgrade.RollingUpgradeDUnitTest
org.apache.geode.security.ClientAuthenticationPart2DUnitTest
org.apache.geode.cache.lucene.LuceneCommandsSecurityDUnitTest
org.apache.geode.management.internal.configuration.ClusterConfigurationIndexWithFromClauseDUnitTest
org.apache.geode.internal.cache.tier.sockets.ClientServerMiscBCDUnitTest
org.apache.geode.cache.lucene.LuceneSearchWithRollingUpgradeDUnit
org.apache.geode.cache.wan.WANRollingUpgradeDUnitTest
org.apache.geode.internal.cache.rollingupgrade.RollingUpgrade2DUnitTest
org.apache.geode.security.ClientAuthenticationDUnitTest
org.apache.geode.security.ClientAuthorizationCQDUnitTest
org.apache.geode.internal.cache.TxCommitMessageBackwardCompatibilityDUnitTest

Issue Links

• links to: GitHub Pull Request #1639