[GEODE-4601] Refactor TcrMessage - resolve accessor encapsulation

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Won't Fix
• Component/s: native client
• Assignee: Unassigned
• Reporter: Addison
• Created: 05/Feb/18 22:18
• Updated: 24/Feb/22 21:02
• Resolved: 24/Feb/22 21:02

Description

TcrMessage has accessor setMessageType() which should be removed from the base class. It is used only on reply messages, not request messages.

Here are some steps we can take:

1. Move it into the TcrMessageReply class.
2. Remove the accessor entirely by altering internal APIs, e.g. TcrMessageHelper::readChunkPartHeader(), to return a message object rather than taking a reference to a message and then modifying the type.