[GEODE-4163] clean up DistributionManager code

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: membership
• Assignee: Unassigned
• Reporter: Bruce J Schuchardt
• Created: 22/Dec/17 22:34
• Updated: 01/Feb/18 22:52
• Resolved: 28/Dec/17 00:44

Description

DistributionManager has a large number of methods that are marked public but should be private.

It has a lot of methods and instance variables that aren't used and a lot of commented-out code.

There are also other classes that cast a DM to DistributionManager in order to use methods marked public instead of adding those methods to the DM interface.

DistributionManager also has instance variable sprinkled throughout the file and lots of raw, untyped collections.

There are also a lot of methods that have InternalDistributedMember in their signatures that were extracted into the DM interface. These should be changed to DistributedMember, the interface that most of our code should use.

All of these problems should be fixed.

Issue Links

• links to: GitHub Pull Request #1206