[GEODE-4083] RegionVersionVector.updateLocalVersion can go into an infinite loop

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.4.0
• Component/s: regions
• Assignee: Eric Shu
• Reporter: Darrel Schneider
• Created: 12/Dec/17 20:39
• Updated: 01/Feb/18 22:51
• Resolved: 14/Dec/17 16:22

Description

RegionVersionVector.updateLocalVersion can go into an infinite loop.
The problem is this code:

  private void updateLocalVersion(long version) {
    boolean repeat = false;
    do {
      long myVersion = this.localVersion.get();
      if (myVersion < version) {
        repeat = !this.localVersion.compareAndSet(myVersion, version);
      }
    } while (repeat);
  }

if version is "1" and localVersion.get() returns "0" the first time it is called but then compareAndSet returns false because localVersion has changed to "2" then the loop will never terminate because repeat will always be false and myVersion ("2" or more) will never be less than version ("1").

The simple fix is to be sure repeat is set to false when myVersion is >= to version.

Issue Links

• links to: GitHub Pull Request #1161