Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-4078

Display full path when locator0vIews.log cannot be opened

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.5.0
    • locator, logging
    • None

    Description

      Tests are often failing with an error such as:

      Could not open log file "locator0views.log"

      Just add the absolute path to help with debugging.

      Attachments

        Issue Links

          Activity

            Commit 33129b12378649d2e121877b4076b6aefc4fd318 in geode's branch refs/heads/develop from jens.deppe
            [ https://gitbox.apache.org/repos/asf?p=geode.git;h=33129b1 ]

            GEODE-4078: Display full path when locator view log cannot be opened (#1154)

            jira-bot ASF subversion and git services added a comment - Commit 33129b12378649d2e121877b4076b6aefc4fd318 in geode's branch refs/heads/develop from jens.deppe [ https://gitbox.apache.org/repos/asf?p=geode.git;h=33129b1 ] GEODE-4078 : Display full path when locator view log cannot be opened (#1154)
            githubbot ASF GitHub Bot added a comment -

            jdeppe-pivotal closed pull request #1154: GEODE-4078: Display full path when locator view log cannot be opened
            URL: https://github.com/apache/geode/pull/1154

            This is a PR merged from a forked repository.
            As GitHub hides the original diff on merge, it is displayed below for
            the sake of provenance:

            As this is a foreign pull request (from a fork), the diff is supplied
            below (as it won't show otherwise due to GitHub magic):

            diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/ProductUseLog.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/ProductUseLog.java
            index 5fda5313da..8ef6fc5fcb 100644
            — a/geode-core/src/main/java/org/apache/geode/distributed/internal/ProductUseLog.java
            +++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/ProductUseLog.java
            @@ -119,7 +119,7 @@ private synchronized void createLogWriter()

            { fos = new FileOutputStream(productUseLogFile, true); }

            catch (FileNotFoundException ex)

            { String s = LocalizedStrings.InternalDistributedSystem_COULD_NOT_OPEN_LOG_FILE_0 - .toLocalizedString(productUseLogFile); + .toLocalizedString(productUseLogFile.getAbsolutePath()); throw new GemFireIOException(s, ex); }

            PrintStream out = new PrintStream(fos);

            ----------------------------------------------------------------
            This is an automated message from the Apache Git Service.
            To respond to the message, please log on GitHub and use the
            URL above to go to the specific comment.

            For queries about this service, please contact Infrastructure at:
            users@infra.apache.org

            githubbot ASF GitHub Bot added a comment - jdeppe-pivotal closed pull request #1154: GEODE-4078 : Display full path when locator view log cannot be opened URL: https://github.com/apache/geode/pull/1154 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/geode-core/src/main/java/org/apache/geode/distributed/internal/ProductUseLog.java b/geode-core/src/main/java/org/apache/geode/distributed/internal/ProductUseLog.java index 5fda5313da..8ef6fc5fcb 100644 — a/geode-core/src/main/java/org/apache/geode/distributed/internal/ProductUseLog.java +++ b/geode-core/src/main/java/org/apache/geode/distributed/internal/ProductUseLog.java @@ -119,7 +119,7 @@ private synchronized void createLogWriter() { fos = new FileOutputStream(productUseLogFile, true); } catch (FileNotFoundException ex) { String s = LocalizedStrings.InternalDistributedSystem_COULD_NOT_OPEN_LOG_FILE_0 - .toLocalizedString(productUseLogFile); + .toLocalizedString(productUseLogFile.getAbsolutePath()); throw new GemFireIOException(s, ex); } PrintStream out = new PrintStream(fos); ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org
            githubbot ASF GitHub Bot added a comment -

            jdeppe-pivotal opened a new pull request #1154: GEODE-4078: Display full path when locator view log cannot be opened
            URL: https://github.com/apache/geode/pull/1154

            Thank you for submitting a contribution to Apache Geode.

            In order to streamline the review of the contribution we ask you
            to ensure the following steps have been taken:

                1. For all changes:
            • [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
            • [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
            • [x] Is your initial contribution a single, squashed commit?
            • [x] Does `gradlew build` run cleanly?
            • [ ] Have you written or updated unit tests to verify your changes?
                1. Note:
                  Please ensure that once the PR is submitted, you check travis-ci for build issues and
                  submit an update to your PR as soon as possible. If you need help, please send an
                  email to dev@geode.apache.org.

            ----------------------------------------------------------------
            This is an automated message from the Apache Git Service.
            To respond to the message, please log on GitHub and use the
            URL above to go to the specific comment.

            For queries about this service, please contact Infrastructure at:
            users@infra.apache.org

            githubbot ASF GitHub Bot added a comment - jdeppe-pivotal opened a new pull request #1154: GEODE-4078 : Display full path when locator view log cannot be opened URL: https://github.com/apache/geode/pull/1154 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [x] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? [x] Is your initial contribution a single, squashed commit? [x] Does `gradlew build` run cleanly? [ ] Have you written or updated unit tests to verify your changes? [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0] ( http://www.apache.org/legal/resolved.html#category-a)? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org

            People

              jens.deppe Jens Deppe
              jens.deppe Jens Deppe
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: