[GEODE-310] HDFSStore API should be more consistent

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Won't Fix
• Component/s: hdfs
• Assignee: Unassigned
• Reporter: Kirk Lund
• Created: 04/Sep/15 19:04
• Updated: 28/Mar/19 23:18
• Resolved: 28/Mar/19 23:18

Description

The public interface for HDFSStore has inconsistencies between method names and constants giving default values and between HDFSStore and other entities such as Region and GatewaySender. These need to be made consistent. A decision also needs to be made whether to include units in the attribute names.

Mismatches between method names and default values:
– HDFSStoreFactory setBatchInterval HDFSStore.DEFAULT_BATCH_INTERVAL_MILLIS
– HDFSStoreFactory.setBatchSize HDFSStore.DEFAULT_BATCH_SIZE_MB
– HDFSStoreFactory.setBufferPersistent GatewaySender.DEFAULT_PERSISTENCE_ENABLED
– HDFSStoreFactory.setDispatcherThreads GatewaySender.DEFAULT_HDFS_DISPATCHER_THREADS
– HDFSStoreFactory.setInputFileSizeMax HDFSStore.DEFAULT_INPUT_FILE_SIZE_MAX_MB
– HDFSStoreFactory.setMajorCompactionInterval HDFSStore.DEFAULT_MAJOR_COMPACTION_INTERVAL_MINS
– HDFSStoreFactory.setMaxMemory GatewaySender.DEFAULT_MAXIMUM_QUEUE_MEMORY
– HDFSStoreFactory.setPurgeInterval HDFSStore.DEFAULT_OLD_FILE_CLEANUP_INTERVAL_MINS
– HDFSStoreFactory.setWriteOnlyFileRolloverSize HDFSStore.DEFAULT_WRITE_ONLY_FILE_SIZE_LIMIT

HDFSStore uses "synchronousDiskWrite" where Region and GatewaySender use "diskSynchronous"

This came up during some of the testing and hydra support for HDFS.