[GEODE-2861] remove deadcode in GemFireCacheImpl and DiskStoreImpl for DiskStoreTaskPool

• Type: Improvement
• Status: Closed
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 1.0.0-incubating
• Fix Version/s: 1.3.0
• Component/s: persistence
• Labels: storage_3
• Assignee: Nick Reich
• Reporter: Darrel Schneider
• Created: 02/May/17 18:15
• Updated: 20/Apr/18 19:54
• Resolved: 28/Jun/17 16:37

Description

Both GemFireCacheImpl and DiskStoreImpl have deadcode related to shutting down the DiskStoreTaskPool.

On DiskStoreImpl see these methods:
stopDiskStoreTaskPool
shutdownPool
On GemFireCacheImpl the field diskStoreTaskPool is always null.

Note that a bug exists in this deadcode that causes it to not call taskCancelled as it iterates over a list of runnables. Since this code is dead it is currently doing no harm but if the code is not removed then make sure and fix this loop.

Issue Links

• links to: GitHub Pull Request #594