Details

    • Task
    • Status: Closed
    • Trivial
    • Resolution: Fixed
    • None
    • 1.3.0
    • None

    Description

      The TXLockToken class doesn't seem to actually be used anywhere in the source. Look into the history and remove it if it's no longer needed.

      Attachments

        Issue Links

          Activity

            githubbot ASF GitHub Bot added a comment -

            GitHub user YehEmily opened a pull request:

            https://github.com/apache/geode/pull/592

            GEODE-2707: Removing TXLockToken

            [View the JIRA ticket here.](https://issues.apache.org/jira/browse/GEODE-2707)

            It seems that there are no other classes that use the `TXLockToken` class, so it was safely removed. It's also an internal class, so it doesn't seem likely that the removal of this class will break any backwards compatibility.

            *Precheckin status: In progress*

            Thank you for submitting a contribution to Apache Geode.

            In order to streamline the review of the contribution we ask you
            to ensure the following steps have been taken:

                1. For all changes:
            • [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
            • [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
            • [ ] Is your initial contribution a single, squashed commit?
            • [ ] Does `gradlew build` run cleanly?
            • [ ] Have you written or updated unit tests to verify your changes?
                1. Note:
                  Please ensure that once the PR is submitted, you check travis-ci for build issues and
                  submit an update to your PR as soon as possible. If you need help, please send an
                  email to dev@geode.apache.org.

            You can merge this pull request into a Git repository by running:

            $ git pull https://github.com/YehEmily/geode GEODE-2707

            Alternatively you can review and apply these changes as the patch at:

            https://github.com/apache/geode/pull/592.patch

            To close this pull request, make a commit to your master/trunk branch
            with (at least) the following in the commit message:

            This closes #592


            commit e51f2047136ea4cdaa09c22a3cc06290e7dd0a01
            Author: YehEmily <emilyyeh1997@gmail.com>
            Date: 2017-06-19T17:36:53Z

            GEODE-2707: Removing TXLockToken (it doesn't appear to be used anywhere, although I still need to check for backwards compatibility issues)


            githubbot ASF GitHub Bot added a comment - GitHub user YehEmily opened a pull request: https://github.com/apache/geode/pull/592 GEODE-2707 : Removing TXLockToken [View the JIRA ticket here.] ( https://issues.apache.org/jira/browse/GEODE-2707 ) It seems that there are no other classes that use the `TXLockToken` class, so it was safely removed. It's also an internal class, so it doesn't seem likely that the removal of this class will break any backwards compatibility. * Precheckin status: In progress * Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: For all changes: [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? [ ] Is your initial contribution a single, squashed commit? [ ] Does `gradlew build` run cleanly? [ ] Have you written or updated unit tests to verify your changes? [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0] ( http://www.apache.org/legal/resolved.html#category-a)? Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to dev@geode.apache.org. You can merge this pull request into a Git repository by running: $ git pull https://github.com/YehEmily/geode GEODE-2707 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/geode/pull/592.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #592 commit e51f2047136ea4cdaa09c22a3cc06290e7dd0a01 Author: YehEmily <emilyyeh1997@gmail.com> Date: 2017-06-19T17:36:53Z GEODE-2707 : Removing TXLockToken (it doesn't appear to be used anywhere, although I still need to check for backwards compatibility issues)
            githubbot ASF GitHub Bot added a comment -

            Github user galen-pivotal commented on the issue:

            https://github.com/apache/geode/pull/592

            đź‘Ť thanks for pushing this through! It had completely fallen off my radar.

            githubbot ASF GitHub Bot added a comment - Github user galen-pivotal commented on the issue: https://github.com/apache/geode/pull/592 đź‘Ť thanks for pushing this through! It had completely fallen off my radar.
            githubbot ASF GitHub Bot added a comment -

            Github user PurelyApplied commented on the issue:

            https://github.com/apache/geode/pull/592

            After the fix Ken pointed out, `++n;`

            githubbot ASF GitHub Bot added a comment - Github user PurelyApplied commented on the issue: https://github.com/apache/geode/pull/592 After the fix Ken pointed out, `++n;`

            Commit b673ff982917561f79fe50d3c9642d50f77f90e7 in geode's branch refs/heads/develop from YehEmily
            [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b673ff9 ]

            GEODE-2707: Removing TXLockToken class and entry in sanctionedDataSerializables.txt

            • this closes #592
            jira-bot ASF subversion and git services added a comment - Commit b673ff982917561f79fe50d3c9642d50f77f90e7 in geode's branch refs/heads/develop from YehEmily [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b673ff9 ] GEODE-2707 : Removing TXLockToken class and entry in sanctionedDataSerializables.txt this closes #592
            githubbot ASF GitHub Bot added a comment -

            Github user asfgit closed the pull request at:

            https://github.com/apache/geode/pull/592

            githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/geode/pull/592

            Commit b673ff982917561f79fe50d3c9642d50f77f90e7 in geode's branch refs/heads/feature/GEODE-3113 from YehEmily
            [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b673ff9 ]

            GEODE-2707: Removing TXLockToken class and entry in sanctionedDataSerializables.txt

            • this closes #592
            jira-bot ASF subversion and git services added a comment - Commit b673ff982917561f79fe50d3c9642d50f77f90e7 in geode's branch refs/heads/feature/ GEODE-3113 from YehEmily [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b673ff9 ] GEODE-2707 : Removing TXLockToken class and entry in sanctionedDataSerializables.txt this closes #592

            Commit b673ff982917561f79fe50d3c9642d50f77f90e7 in geode's branch refs/heads/feature/GEODE-3251 from YehEmily
            [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b673ff9 ]

            GEODE-2707: Removing TXLockToken class and entry in sanctionedDataSerializables.txt

            • this closes #592
            jira-bot ASF subversion and git services added a comment - Commit b673ff982917561f79fe50d3c9642d50f77f90e7 in geode's branch refs/heads/feature/ GEODE-3251 from YehEmily [ https://git-wip-us.apache.org/repos/asf?p=geode.git;h=b673ff9 ] GEODE-2707 : Removing TXLockToken class and entry in sanctionedDataSerializables.txt this closes #592

            People

              eyeh Emily Yeh
              gosullivan Galen O'Sullivan
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: