[GEODE-1934] Failure from RDDJoinRegionIntegrationTest

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.0.0-incubating
• Component/s: tests
• Assignee: Dan Smith
• Reporter: Dan Smith
• Created: 23/Sep/16 23:24
• Updated: 25/Oct/16 07:17
• Resolved: 26/Sep/16 15:38

Description

This test is failing in the nightly build for the spark integration.

It looks like the issue is that it's missing the StringUtils class, which is part of spring core:

sbt.ForkMain$ForkError: org/springframework/util/StringUtils
	at org.apache.geode.internal.net.SSLConfigurationFactory.configureSSLPropertiesFromSystemProperties(SSLConfigurationFactory.java:274)
	at org.apache.geode.internal.net.SSLConfigurationFactory.configureSSLPropertiesFromSystemProperties(SSLConfigurationFactory.java:270)
	at org.apache.geode.internal.net.SSLConfigurationFactory.createSSLConfigForComponent(SSLConfigurationFactory.java:138)
	at org.apache.geode.internal.net.SSLConfigurationFactory.getSSLConfigForComponent(SSLConfigurationFactory.java:67)
	at org.apache.geode.internal.net.SocketCreatorFactory.getSocketCreatorForComponent(SocketCreatorFactory.java:67)
	at org.apache.geode.distributed.internal.tcpserver.TcpClient.<init>(TcpClient.java:69)
	at org.apache.geode.cache.client.internal.AutoConnectionSourceImpl.<init>(AutoConnectionSourceImpl.java:114)
	at org.apache.geode.cache.client.internal.PoolImpl.getSourceImpl(PoolImpl.java:579)
	at org.apache.geode.cache.client.internal.PoolImpl.<init>(PoolImpl.java:219)
	at org.apache.geode.cache.client.internal.PoolImpl.create(PoolImpl.java:132)
	at org.apache.geode.internal.cache.PoolFactoryImpl.create(PoolFactoryImpl.java:319)
	at org.apache.geode.internal.cache.GemFireCacheImpl.determineDefaultPool(GemFireCacheImpl.java:2943)
	at org.apache.geode.internal.cache.GemFireCacheImpl.initializeDeclarativeCache(GemFireCacheImpl.java:1293)
	at org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1124)
	at org.apache.geode.internal.cache.GemFireCacheImpl.basicCreate(GemFireCacheImpl.java:765)
	at org.apache.geode.internal.cache.GemFireCacheImpl.createClient(GemFireCacheImpl.java:740)
	at org.apache.geode.cache.client.ClientCacheFactory.basicCreate(ClientCacheFactory.java:235)
	at org.apache.geode.cache.client.ClientCacheFactory.create(ClientCacheFactory.java:189)
	at org.apache.geode.spark.connector.internal.DefaultGeodeConnection.initClientCache(DefaultGeodeConnection.scala:52)
	at org.apache.geode.spark.connector.internal.DefaultGeodeConnection.<init>(DefaultGeodeConnection.scala:43)
	at org.apache.geode.spark.connector.internal.DefaultGeodeConnectionFactory.newConnection(DefaultGeodeConnection.scala:162)
	at org.apache.geode.spark.connector.internal.DefaultGeodeConnectionManager$.getConnection(DefaultGeodeConnectionManager.scala:59)
	at org.apache.geode.spark.connector.internal.DefaultGeodeConnectionManager.getConnection(DefaultGeodeConnectionManager.scala:29)
	at org.apache.geode.spark.connector.GeodeConnectionConf.getConnection(GeodeConnectionConf.scala:39)
	at ittest.org.apache.geode.spark.connector.RDDJoinRegionIntegrationTest.verifyPairRDDJoinRegionWithSameKeyType(RDDJoinRegionIntegrationTest.scala:89)
	at ittest.org.apache.geode.spark.connector.RDDJoinRegionIntegrationTest$$anonfun$1.apply$mcV$sp(RDDJoinRegionIntegrationTest.scala:73)
	at ittest.org.apache.geode.spark.connector.RDDJoinRegionIntegrationTest$$anonfun$1.apply(RDDJoinRegionIntegrationTest.scala:73)
	at ittest.org.apache.geode.spark.connector.RDDJoinRegionIntegrationTest$$anonfun$1.apply(RDDJoinRegionIntegrationTest.scal

Looking at our pom.xml file for geode-core, this is not suprising because spring-core is marked as an optional dependency. I think the dependencies of geode-core are messed, either spring-core should not be marked optional or we should not be depending on it. These are the places that are using spring-core in geode-core:

./gradlew geode-core:findUsage -Djar.name=spring-core

Matches
========
org/apache/geode/management/internal/cli/shell/GfshExecutionStrategy.java
org/apache/geode/management/internal/cli/converters/DirConverter.java
org/apache/geode/management/internal/cli/util/CommentSkipHelper.java
org/apache/geode/management/internal/cli/multistep/CLIMultiStepHelper.java
org/apache/geode/management/internal/cli/remote/RemoteExecutionStrategy.java
org/apache/geode/management/internal/cli/parser/GfshMethodTarget.java
org/apache/geode/management/internal/configuration/domain/XmlEntity.java
org/apache/geode/management/internal/web/util/ConvertUtils.java
org/apache/geode/management/internal/web/io/MultipartFileResourceAdapter.java
org/apache/geode/management/internal/web/http/converter/SerializableObjectHttpMessageConverter.java
org/apache/geode/management/internal/web/http/ClientHttpRequest.java
org/apache/geode/pdx/internal/PdxInstanceImpl.java
org/apache/geode/internal/net/SocketCreator.java