Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-1642

Add conveniance method isCancelInProgress to CancelCriterion

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Major
    • Resolution: Fixed
    • None
    • 1.0.0-incubating.M3
    • general
    • None

    Description

      Geode's code has a lot of cancellation checks that look like this:

      if (cache.getCancelCriterion().cancelInProgress() != null)

      It seems very odd to have to perform a null check to see if the cache is shutting down. CancelCriterion should have a isCancelInProgress() method that can be used instead of the null check.

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            bschuchardt Bruce J Schuchardt
            bschuchardt Bruce J Schuchardt
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment