[GEODE-10412] Destroy region command doesn't clear the region related expired tombstones

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.15.1, 1.16.0
• Component/s: expiration
• Labels: pull-request-available
• Assignee: Jakov Varenina
• Reporter: Jakov Varenina
• Created: 26/Aug/22 07:46
• Updated: 10/Oct/22 20:20
• Resolved: 30/Aug/22 06:41

Description

Tombstones in geode are kept on two maps: expiredTombstones and tombstones (non-expired ones). When a region is destroyed, it must clear all the related expired and non-expired tombstones from memory. Due to the below code bug, expired tombstones aren't cleared when non-expired tombstones are available during the region destruction:

private boolean removeIf(Predicate<Tombstone> predicate) {      
  return removeUnexpiredIf(predicate) || removeExpiredIf(predicate);    
}

Because of the above, non-expired tombstones are never removed from memory, preventing other tombstones from being cleared. Since other tombstones never expire, the compaction is not done, and therefore the disk is filled, causing the issues.

Issue Links

• links to: GitHub Pull Request #7838