[GEODE-10358] Add test coverage for LOCATOR_DM_TYPE and NORMAL_DM_TYPE

• Type: Wish
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: membership, tests
• Labels: pull-request-available
• Assignee: Kirk Lund
• Reporter: Kirk Lund
• Created: 02/Jun/22 21:14
• Updated: 22/Jun/22 22:11

Description

Add test coverage for LOCATOR_DM_TYPE and NORMAL_DM_TYPE.

PR #6225 is trying to redefine the nodes stat in DistributionStats. Understanding why this change is not allowed requires understanding the difference between LOCATOR_DM_TYPE and NORMAL_DM_TYPE.

Servers and Locators started via Gfsh are both of type NORMAL_DM_TYPE, however, some locators are of the type LOCATOR_DM_TYPE.

Older scripts and tools set:

System.setProperty(InternalLocator.FORCE_LOCATOR_DM_TYPE, "true");

which then results in the locator in that JVM having LOCATOR_DM_TYPE. Otherwise is of type NORMAL_DM_TYPE. Usage of FORCE_LOCATOR_DM_TYPE is considered an API until Geode 2.0 because it was documented for Users at some point and has been actively used in scripting and tooling for Geode.

DistributionStats nodes is defined as NOT counting processes of type LOCATOR_DM_TYPE.

Issue Links

• links to: GitHub Pull Request #7765