[GEODE-10337] SocketCreatorFactory does not null out instance static

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 1.16.0
• Component/s: membership
• Labels: blocks-1.16.0 pull-request-available
• Assignee: Mario Ivanac
• Reporter: Darrel Schneider
• Created: 25/May/22 22:22
• Updated: 07/Sep/22 13:17
• Resolved: 07/Sep/22 13:17

Description

The SocketCreatorFactory has a static "instance" field that keeps the singleton factory. The factory has a reference in "distributionConfig" that ends up keeping the InternalDistributedSystem alive after disconnect.
It also has a static close method but the product never calls it.
To fix this leak do the following:
On InternalDistributedSystem.disconnect add to the end of it:

          if (!attemptingToReconnect) {
            SocketCreatorFactory.close();
          }

Also I think it would be good to change SocketCreatorFactory.getInstance to null out the static when close it called like so:

  private static synchronized SocketCreatorFactory getInstance(boolean closing) {
    SocketCreatorFactory result = instance;
    if (result == null && !closing) {
      result = new SocketCreatorFactory();
      instance = result;
    } else if (result != null && closing) {
      instance = null;
    }
    return result;
  }

Issue Links

• links to: GitHub Pull Request #7842