[GEODE-10191] BLPOP command does not trigger when the target List is created via a RENAME

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.15.0
• Fix Version/s: 1.15.0
• Component/s: redis
• Labels: blocks-1.15.0​ pull-request-available
• Assignee: Jens Deppe
• Reporter: Donal Evans
• Created: 29/Mar/22 18:13
• Updated: 22/Jun/22 20:46
• Resolved: 01/Apr/22 03:28

Description

BLPOP uses fired events from the LPUSH and RPUSH commands to trigger returning, but it is also possible that a key will be created via RENAME, which does not currently fire any events. The test below passes with open source Redis but fails/hangs with geode-for-redis:

@Test
public void testBLPopWhenValueGetsCreated_withRename() throws Exception {
  String initialName = "{tag}initial";
  String changedName = "{tag}changed";
  jedis.lpush(initialName, "value1", "value2");
  Future<List<String>> future = executor.submit(() -> jedis.blpop(0, changedName));

  awaitEventDistributorSize(1);
  jedis.rename(initialName, changedName);

  assertThat(future.get()).containsExactly(changedName, "value2");
  assertThat(jedis.lpop(changedName)).isEqualTo("value1");
} 

The RENAME command should be modified so that it fires events for the key being created.

Issue Links

• links to: GitHub Pull Request #7537