Uploaded image for project: 'Geode'
  1. Geode
  2. GEODE-10190

Improve runtime of some Redis integration tests

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    Description

      From Darrel:

      I’m doing some refactoring of the ResourceManager and my pr’s integration tests are timing out after running for 45 minutes. Normally integration tests take 18 minutes. When looking at whats tests took a long time I see that AbstractRenameIntegrationTest#shouldRenameAtomically took 8 minutes each time it was run. On my laptop I see it run in 2.75 minutes. Another test method I see take over 7 minutes is testMSet_concurrentInstances_mustBeAtomic. These two methods are run twice so that adds up to 30 minutes in just two test methods so I think that is the cause of the timeout. Both of these do concurrency. Any ideas about this? Do you think my refactoring broke something or did I just get a bad run of these tests?

       

       

      Attachments

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jens.deppe Jens Deppe
            jens.deppe Jens Deppe
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment