Uploaded image for project: 'Apache Gearpump'
  1. Apache Gearpump
  2. GEARPUMP-379

Client doesn't exit when the application is terminated

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 0.8.4
    • 0.8.5
    • client
    • None

    Attachments

      Issue Links

        Activity

          githubbot ASF GitHub Bot added a comment -

          GitHub user manuzhang opened a pull request:

          https://github.com/apache/incubator-gearpump/pull/249

          GEARPUMP-379 Send terminated status to client when an application i…

          …s terminated

          Be sure to do all of the following to help us incorporate your contribution
          quickly and easily:

          • [ ] Make sure the commit message is formatted like:
            `GEARPUMP-<Jira issue #> Meaningful description of pull request`
          • [ ] Make sure tests pass via `sbt clean test`.
          • [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality.

          You can merge this pull request into a Git repository by running:

          $ git pull https://github.com/manuzhang/incubator-gearpump gearpump_379

          Alternatively you can review and apply these changes as the patch at:

          https://github.com/apache/incubator-gearpump/pull/249.patch

          To close this pull request, make a commit to your master/trunk branch
          with (at least) the following in the commit message:

          This closes #249


          commit 61ca316123b402fa28ef05cc90147b710c71f629
          Author: manuzhang <owenzhang1990@...>
          Date: 2018-06-09T11:35:10Z

          GEARPUMP-379 Send terminated status to client when an application is terminated


          githubbot ASF GitHub Bot added a comment - GitHub user manuzhang opened a pull request: https://github.com/apache/incubator-gearpump/pull/249 GEARPUMP-379 Send terminated status to client when an application i… …s terminated Be sure to do all of the following to help us incorporate your contribution quickly and easily: [ ] Make sure the commit message is formatted like: ` GEARPUMP-<Jira issue #> Meaningful description of pull request` [ ] Make sure tests pass via `sbt clean test`. [ ] Make sure old documentation affected by the pull request has been updated and new documentation added for new functionality. You can merge this pull request into a Git repository by running: $ git pull https://github.com/manuzhang/incubator-gearpump gearpump_379 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-gearpump/pull/249.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #249 commit 61ca316123b402fa28ef05cc90147b710c71f629 Author: manuzhang <owenzhang1990@...> Date: 2018-06-09T11:35:10Z GEARPUMP-379 Send terminated status to client when an application is terminated
          githubbot ASF GitHub Bot added a comment -

          Github user codecov-io commented on the issue:

          https://github.com/apache/incubator-gearpump/pull/249

          1. [Codecov](https://codecov.io/gh/apache/incubator-gearpump/pull/249?src=pr&el=h1) Report
            > Merging 249(https://codecov.io/gh/apache/incubator-gearpump/pull/249?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-gearpump/commit/504bcf39cd7c64127d3290f56c644f07bf5dd7b5?src=pr&el=desc) will *increase* coverage by `1.21%`.
            > The diff coverage is `16.66%`.

          ```diff
          @@ Coverage Diff @@

            1. master #249 +/- ##
              ==========================================
              + Coverage 68.4% 69.62% +1.21%
              ==========================================
              Files 195 195
              Lines 6229 6235 +6
              Branches 541 540 -1
              ==========================================
              + Hits 4261 4341 +80
              + Misses 1968 1894 -74
              ```
          githubbot ASF GitHub Bot added a comment - Github user codecov-io commented on the issue: https://github.com/apache/incubator-gearpump/pull/249 [Codecov] ( https://codecov.io/gh/apache/incubator-gearpump/pull/249?src=pr&el=h1 ) Report > Merging 249 ( https://codecov.io/gh/apache/incubator-gearpump/pull/249?src=pr&el=desc ) into [master] ( https://codecov.io/gh/apache/incubator-gearpump/commit/504bcf39cd7c64127d3290f56c644f07bf5dd7b5?src=pr&el=desc ) will * increase * coverage by `1.21%`. > The diff coverage is `16.66%`. ```diff @@ Coverage Diff @@ master #249 +/- ## ========================================== + Coverage 68.4% 69.62% +1.21% ========================================== Files 195 195 Lines 6229 6235 +6 Branches 541 540 -1 ========================================== + Hits 4261 4341 +80 + Misses 1968 1894 -74 ```
          githubbot ASF GitHub Bot added a comment -

          Github user huafengw commented on the issue:

          https://github.com/apache/incubator-gearpump/pull/249

          +1

          githubbot ASF GitHub Bot added a comment - Github user huafengw commented on the issue: https://github.com/apache/incubator-gearpump/pull/249 +1
          githubbot ASF GitHub Bot added a comment -

          Github user asfgit closed the pull request at:

          https://github.com/apache/incubator-gearpump/pull/249

          githubbot ASF GitHub Bot added a comment - Github user asfgit closed the pull request at: https://github.com/apache/incubator-gearpump/pull/249
          mauzhang Manu Zhang added a comment -

          Issue resolved by pull request 249
          https://github.com/apache/incubator-gearpump/pull/249

          mauzhang Manu Zhang added a comment - Issue resolved by pull request 249 https://github.com/apache/incubator-gearpump/pull/249

          People

            mauzhang Manu Zhang
            mauzhang Manu Zhang
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: