Commons Functor
  1. Commons Functor
  2. FUNCTOR-22

Generify ComparableComparator

        Details

        • Type: Improvement Improvement
        • Status: Resolved
        • Priority: Trivial Trivial
        • Resolution: Fixed
        • Affects Version/s: None
        • Fix Version/s: None
        • Labels:
        • Environment:

          Java 1.6
          Eclipse Juno
          Debian 6 3.2

          Description

          From http://markmail.org/search/?q=list%3Aorg.apache.commons.dev/#query:list%3Aorg.apache.commons.dev%2F+page:3+mid:ei6pac2nersyokzr+state:results

          The class ComparableComparator is not using Generics and was created from commons-collection ComparableComparator, that is using Generics.

            Activity

            Ascending order - Click to sort in descending order
            Bruno P. Kinoshita created issue -
            Hide
            Permalink
            Bruno P. Kinoshita added a comment -

            Author: kinow
            Date: Mon Jul 23 15:21:25 2012
            New Revision: 1364676

            URL: http://svn.apache.org/viewvc?rev=1364676&view=rev
            Log:
            FUNCTOR-22 Added generics to ComparableComparator. Few other classes that used the ComparableComparator were updated too. Tests were also updated accordingly.

            Modified:
            commons/proper/functor/trunk/src/changes/changes.xml
            commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java
            commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparatorFunction.java
            commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsEquivalent.java
            commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsGreaterThan.java
            commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsGreaterThanOrEqual.java
            commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsLessThan.java
            commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsLessThanOrEqual.java
            commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsNotEquivalent.java
            commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/Max.java
            commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/Min.java
            commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestComparableComparator.java
            commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestComparatorFunction.java
            commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsEquivalent.java
            commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsGreaterThan.java
            commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsGreaterThanOrEqual.java
            commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsLessThan.java
            commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsLessThanOrEqual.java
            commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsNotEquivalent.java
            commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestMax.java
            commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestMin.java

            Show
            Bruno P. Kinoshita added a comment - Author: kinow Date: Mon Jul 23 15:21:25 2012 New Revision: 1364676 URL: http://svn.apache.org/viewvc?rev=1364676&view=rev Log: FUNCTOR-22 Added generics to ComparableComparator. Few other classes that used the ComparableComparator were updated too. Tests were also updated accordingly. Modified: commons/proper/functor/trunk/src/changes/changes.xml commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparableComparator.java commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/ComparatorFunction.java commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsEquivalent.java commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsGreaterThan.java commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsGreaterThanOrEqual.java commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsLessThan.java commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsLessThanOrEqual.java commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/IsNotEquivalent.java commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/Max.java commons/proper/functor/trunk/src/main/java/org/apache/commons/functor/core/comparator/Min.java commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestComparableComparator.java commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestComparatorFunction.java commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsEquivalent.java commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsGreaterThan.java commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsGreaterThanOrEqual.java commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsLessThan.java commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsLessThanOrEqual.java commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestIsNotEquivalent.java commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestMax.java commons/proper/functor/trunk/src/test/java/org/apache/commons/functor/core/comparator/TestMin.java
            Hide
            Permalink
            Bruno P. Kinoshita added a comment -

            Fixed in r1364676.

            Show
            Bruno P. Kinoshita added a comment - Fixed in r1364676 .
            Bruno P. Kinoshita made changes -
            Field Original Value New Value
            Status Open [ 1 ] Resolved [ 5 ]
            Resolution Fixed [ 1 ]

              People

              • Assignee:
                Bruno P. Kinoshita
                Reporter:
                Bruno P. Kinoshita
              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development