Uploaded image for project: 'FtpServer'
  1. FtpServer
  2. FTPSERVER-506

Binary compatibility is broken in ftpserver-core since 1.1.3, 1.2.0 vs 1.1.2

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 1.1.3, 1.2.0
    • 1.1.5, 1.2.1
    • Core
    • None

    Description

      Over at Apache Commons, when we update Commons Net from 1.1.2 to 1.1.3, we get compile errors:

      [INFO] --- maven-compiler-plugin:3.8.1:testCompile (default-testCompile) @ commons-net ---
      [INFO] Changes detected - recompiling the module!
      [INFO] Compiling 63 source files to /home/runner/work/commons-net/commons-net/target/test-classes
      [INFO] -------------------------------------------------------------
      Error:  COMPILATION ERROR : 
      [INFO] -------------------------------------------------------------
      Error:  /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8] org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract and does not override abstract method getEnabledProtocols() in org.apache.ftpserver.ssl.SslConfiguration
      Error:  /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5] method does not override or implement a method from a supertype
      [INFO] 2 errors 
      [INFO] -------------------------------------------------------------
      [INFO] ------------------------------------------------------------------------
      [INFO] BUILD FAILURE
      [INFO] ------------------------------------------------------------------------
      [INFO] Total time:  20.310 s
      [INFO] Finished at: 2022-03-04T02:17:14Z
      [INFO] ------------------------------------------------------------------------
      Error:  Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project commons-net: Compilation failure: Compilation failure: 
      Error:  /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[30,8] org.apache.commons.net.ftp.NoProtocolSslConfigurationProxy is not abstract and does not override abstract method getEnabledProtocols() in org.apache.ftpserver.ssl.SslConfiguration
      Error:  /home/runner/work/commons-net/commons-net/src/test/java/org/apache/commons/net/ftp/NoProtocolSslConfigurationProxy.java:[32,5] method does not override or implement a method from a supertype
      Error:  -> [Help 1]
      Error:  
      Error:  To see the full stack trace of the errors, re-run Maven with the -e switch.
      Error:  Re-run Maven using the -X switch to enable full debug logging.
      Error:  
      Error:  For more information about the errors and possible solutions, please read the following articles:
      Error:  [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
      Error: Process completed with exit code 1.
      

      See PR Bump ftpserver-core from 1.1.2 to 1.1.3 Java CI #429: https://github.com/apache/commons-net/runs/5416642453?check_suite_focus=true

      Please don't break BC! That should be rule #1 IMO.

      Attachments

        Activity

          People

            Unassigned Unassigned
            ggregory Gary D. Gregory
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0h
                0h
                Logged:
                Time Spent - 1h 20m
                1h 20m