FtpServer
  1. FtpServer
  2. FTPSERVER-412

OPTS MLST does not handle unknown factnames correctly

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.5
    • Fix Version/s: 1.0.6, 1.1.0
    • Component/s: None
    • Labels:
      None

      Description

      RFC 3659, section 7.9 states "Facts requested that are not supported, or that are inappropriate to the file or directory being listed should simply be omitted from the MLSx output. This is not an error. Note that where no factname arguments are present, the client is requesting that only the file names be returned."

      org.apache.ftpserver.command.impl.OPTS_MLST.validateSelectedTypes() specifically returns null if one of the types requested is not found, and a null return generates the 501 from execute().

      1. OPTS_MLST.java
        4 kB
        Allen Firstenberg

        Activity

        Hide
        Niklas Gustavsson added a comment -

        Fixed in rev 1101807 and 1101808. I did not use the provided patch, please verify if the fix solves your issue.

        Show
        Niklas Gustavsson added a comment - Fixed in rev 1101807 and 1101808. I did not use the provided patch, please verify if the fix solves your issue.
        Hide
        Allen Firstenberg added a comment -

        Attached is a fix. All the functions required changes since both the parameter parsing did not correctly handle no features, as well as features that were not supported, and the return message was not according to spec.

        Show
        Allen Firstenberg added a comment - Attached is a fix. All the functions required changes since both the parameter parsing did not correctly handle no features, as well as features that were not supported, and the return message was not according to spec.

          People

          • Assignee:
            Niklas Gustavsson
            Reporter:
            Allen Firstenberg
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development