Uploaded image for project: 'FtpServer'
  1. FtpServer
  2. FTPSERVER-360

When no passive ports are available error out immediately rather than waiting for a port to become available

    Details

    • Type: Bug
    • Status: Open
    • Priority: Major
    • Resolution: Unresolved
    • Affects Version/s: 1.0.4
    • Fix Version/s: 1.0.0-M1, 1.1.2
    • Component/s: None
    • Labels:
      None

      Description

      Based on the filed issue, http://issues.apache.org/jira/browse/FTPSERVER-359, we probably want to quick fix the code to error out right away when no passive port is available.

      1. FTPSERVER-360.patch
        2 kB
        Sai Pullabhotla

        Activity

        Hide
        psai Sai Pullabhotla added a comment -

        I think this was already fixed. Can this be closed?

        Show
        psai Sai Pullabhotla added a comment - I think this was already fixed. Can this be closed?
        Hide
        niklas Niklas Gustavsson added a comment -

        I think this should go in trunk and 1.0.x (to fix the bug reported in 1.0.x).

        I've fixed the forgotten move from branches to tags. My bad.

        Show
        niklas Niklas Gustavsson added a comment - I think this should go in trunk and 1.0.x (to fix the bug reported in 1.0.x). I've fixed the forgotten move from branches to tags. My bad.
        Hide
        psai Sai Pullabhotla added a comment -

        Okay, I think I got a test case for this. What all branches do you want this fix to go in, in addition to the trunk?

        A side note - I do see two branches - 1.0.4 and 1.0.x. However, I do not see a 1.0.4 tag. Did we create a branch for 1.0.4 where it should have been a tag?

        Show
        psai Sai Pullabhotla added a comment - Okay, I think I got a test case for this. What all branches do you want this fix to go in, in addition to the trunk? A side note - I do see two branches - 1.0.4 and 1.0.x. However, I do not see a 1.0.4 tag. Did we create a branch for 1.0.4 where it should have been a tag?
        Hide
        niklas Niklas Gustavsson added a comment -

        Yeah, that's right.

        Show
        niklas Niklas Gustavsson added a comment - Yeah, that's right.
        Hide
        psai Sai Pullabhotla added a comment -

        Niklas,

        Are you looking for a "client" test case, to actually connect to the server and try opening passive connections? Otherwise, the current test cases are good enough.

        Show
        psai Sai Pullabhotla added a comment - Niklas, Are you looking for a "client" test case, to actually connect to the server and try opening passive connections? Otherwise, the current test cases are good enough.
        Hide
        niklas Niklas Gustavsson added a comment -

        Patche seems good, we also need a test case to show that we now return an error if the passive ports are used.

        Show
        niklas Niklas Gustavsson added a comment - Patche seems good, we also need a test case to show that we now return an error if the passive ports are used.
        Hide
        psai Sai Pullabhotla added a comment -

        Here is a patch to try out to see if the server locks up as reported in the issue 359. This patch error out immediately when no passive ports are available. This is mainly for testing with the test case provided the submitter of FTPSERVER-359. Not sure if it is ready to be included in the code base.

        Show
        psai Sai Pullabhotla added a comment - Here is a patch to try out to see if the server locks up as reported in the issue 359. This patch error out immediately when no passive ports are available. This is mainly for testing with the test case provided the submitter of FTPSERVER-359 . Not sure if it is ready to be included in the code base.

          People

          • Assignee:
            psai Sai Pullabhotla
            Reporter:
            psai Sai Pullabhotla
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development