FtpServer
  1. FtpServer
  2. FTPSERVER-347

Multiline replies does not handle lines starting with numbers

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.0.0, 1.0.1, 1.0.2, 1.0.3
    • Fix Version/s: 1.0.4, 1.1.0
    • Component/s: Core, Ftplets
    • Labels:
      None

      Description

      For multiline replies, any line staring with a number should be indented with two spaces according to the example in the RFC. We do not currently do that, instead printing the line without any prefix, making it potentially confusing clients.

        Activity

        Hide
        Niklas Gustavsson added a comment -

        Fixed in rev 911609
        commit -m "Fixing bug where we did not correctly handle multiline replies with lines starting with numbers (FTPSERVER-347)" /Users/niklas/Documents/svn/ftpserver-1.0.x/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/DefaultFtpReply.java /Users/niklas/Documents/svn/ftpserver-trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/DefaultFtpReply.java /Users/niklas/Documents/svn/ftpserver-1.0.x/core/src/test/java/org/apache/ftpserver/impl/DefaultFtpReplyTest.java /Users/niklas/Documents/svn/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/impl/DefaultFtpReplyTest.java
        Sending /Users/niklas/Documents/svn/ftpserver-1.0.x/core/src/test/java/org/apache/ftpserver/impl/DefaultFtpReplyTest.java
        Sending /Users/niklas/Documents/svn/ftpserver-1.0.x/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/DefaultFtpReply.java
        Sending /Users/niklas/Documents/svn/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/impl/DefaultFtpReplyTest.java
        Sending /Users/niklas/Documents/svn/ftpserver-trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/DefaultFtpReply.java
        Transmitting file data ...
        Committed revision 911609.

        Show
        Niklas Gustavsson added a comment - Fixed in rev 911609 commit -m "Fixing bug where we did not correctly handle multiline replies with lines starting with numbers ( FTPSERVER-347 )" /Users/niklas/Documents/svn/ftpserver-1.0.x/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/DefaultFtpReply.java /Users/niklas/Documents/svn/ftpserver-trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/DefaultFtpReply.java /Users/niklas/Documents/svn/ftpserver-1.0.x/core/src/test/java/org/apache/ftpserver/impl/DefaultFtpReplyTest.java /Users/niklas/Documents/svn/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/impl/DefaultFtpReplyTest.java Sending /Users/niklas/Documents/svn/ftpserver-1.0.x/core/src/test/java/org/apache/ftpserver/impl/DefaultFtpReplyTest.java Sending /Users/niklas/Documents/svn/ftpserver-1.0.x/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/DefaultFtpReply.java Sending /Users/niklas/Documents/svn/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/impl/DefaultFtpReplyTest.java Sending /Users/niklas/Documents/svn/ftpserver-trunk/ftplet-api/src/main/java/org/apache/ftpserver/ftplet/DefaultFtpReply.java Transmitting file data ... Committed revision 911609.

          People

          • Assignee:
            Niklas Gustavsson
            Reporter:
            Niklas Gustavsson
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development