[FTPSERVER-259] Connection statistics not updated

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0-M4
• Fix Version/s: 1.0.0-RC1
• Component/s: Core
• Assignee: Niklas Therning
• Reporter: Jiri Kuhn
• Created: 07/Jan/09 15:26
• Updated: 09/Jan/09 21:40
• Resolved: 09/Jan/09 21:40

Description

Methods

org.apache.ftpserver.impl.ServerFtpStatistics#setOpenConnection(FtpIoSession)
org.apache.ftpserver.impl.ServerFtpStatistics#setCloseConnection(FtpIoSession)

are never called from production code.

Command SITE_STAT shows only zeros for connection statistics.

Really, really side note: I have looked at DefaultFtpStatistics class. The counters are AtomicIntegers. As all counters are modified inside synchronized methods, I don't think there is any need for the counters to be AtomicInteger at all. Just int should be enough.