[FTPSERVER-184] IODataConnection ASCII mode does not work as expected.

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 1.0.0-M2, 1.0.0-M3
• Fix Version/s: 1.0.0-M4
• Component/s: Core
• Assignee: Niklas Therning
• Reporter: David Latorre
• Created: 24/Sep/08 10:36
• Updated: 28/Nov/08 18:57
• Resolved: 28/Nov/08 18:57

Description

New lines in files sent in ASCII mode are transformed into /r/n no matter what platform the ftp server is running on. But if I'm not wrong, the new EOL should be equal to "line.separator" . If ASCII mode is going to be supported, this ought to be changed.

The code in IODataConnection.transfer()
{
if (isAscii) {
for (int i = 0; i < count; ++i) {
byte b = buff[i];
if (b == '\n' && !lastWasCR)

{ bos.write('\r'); }

if (b == '\r')

{ lastWasCR = true; }

else

{ lastWasCR = false; }

bos.write(b);
}
}
}