FtpServer
  1. FtpServer
  2. FTPSERVER-165

FileSystemBeanDefinitionParser tries to set the property "create-home" instead of createHome.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.0.0-M2, 1.0.0-M3
    • Fix Version/s: 1.0.0-M2, 1.0.0-M3
    • Component/s: None
    • Labels:
      None

      Description

      Current code is :
      builder.addPropertyValue("create-home", Boolean
      .parseBoolean(element.getAttribute("create-home")));

      but it should be:
      builder.addPropertyValue("createHome", Boolean
      .parseBoolean(element.getAttribute("create-home")));

      Besides, the xml file used in the tests has no create-home property so the bug remained unnoticed in the tests.

      1. config-spring-xml.patch
        0.5 kB
        David Latorre
      2. createHomePatch.patch
        0.6 kB
        David Latorre

        Activity

        Hide
        David Latorre added a comment -

        Patch that solves this problem.

        Show
        David Latorre added a comment - Patch that solves this problem.
        Hide
        Niklas Gustavsson added a comment -

        Patches applied, and I added in a test as well. Thanks!

        svn commit "/media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/config/spring/FileSystemBeanDefinitionParser.java" "/media/big/home/svn/apache/ftpserver-trunk/core/src/test/resources/spring-config/config-spring-1.xml" "/media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/SpringConfigTest.java" -m "FileSystemBeanDefinitionParser tries to set the property "create-home" instead of createHome (FTPSERVER-165)" --username "ngn"
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/config/spring/FileSystemBeanDefinitionParser.java
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/SpringConfigTest.java
        M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/resources/spring-config/config-spring-1.xml
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/config/spring/FileSystemBeanDefinitionParser.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/SpringConfigTest.java
        Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/resources/spring-config/config-spring-1.xml
        Committed revision 687013

        Show
        Niklas Gustavsson added a comment - Patches applied, and I added in a test as well. Thanks! svn commit "/media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/config/spring/FileSystemBeanDefinitionParser.java" "/media/big/home/svn/apache/ftpserver-trunk/core/src/test/resources/spring-config/config-spring-1.xml" "/media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/SpringConfigTest.java" -m "FileSystemBeanDefinitionParser tries to set the property "create-home" instead of createHome ( FTPSERVER-165 )" --username "ngn" M /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/config/spring/FileSystemBeanDefinitionParser.java M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/SpringConfigTest.java M /media/big/home/svn/apache/ftpserver-trunk/core/src/test/resources/spring-config/config-spring-1.xml Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/main/java/org/apache/ftpserver/config/spring/FileSystemBeanDefinitionParser.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/java/org/apache/ftpserver/config/spring/SpringConfigTest.java Transmitting file data: /media/big/home/svn/apache/ftpserver-trunk/core/src/test/resources/spring-config/config-spring-1.xml Committed revision 687013

          People

          • Assignee:
            Niklas Gustavsson
            Reporter:
            David Latorre
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - 5m
              5m
              Remaining:
              Remaining Estimate - 5m
              5m
              Logged:
              Time Spent - Not Specified
              Not Specified

                Development