[FOR-987] Redundant code in forrest.build.xml

• Type: Improvement
• Status: Open
• Priority: Trivial
• Resolution: Unresolved
• Affects Version/s: 0.8
• Component/s: Core operations
• Urgency: Low
• Assignee: Unassigned
• Reporter: Ross Gardler
• Created: 13/Apr/07 19:28
• Updated: 13/Apr/07 23:57

Description

In forrest.build.xml there is the followoing target:

<!-- Load properties from Forrest's default skinconf.xml, unless a user's is defined -->
  <target name="load-forrest-props" unless="skinconf.present">
    <xslt in="${forrest.core.webapp}/skinconf.xml"
           out="${project.temp-dir}/no-doctype-forrest-skinconf.xml"
           style="${forrest.core.webapp}/resources/stylesheets/strip-doctype.xsl">
      <xmlcatalog refid="fcatalog"/>
    </xslt>
<!-- Forrest skinconf should have been previously validated in build.xml -->
    <xmlproperty file="${project.temp-dir}/no-doctype-forrest-skinconf.xml"
                 collapseattributes="true"/>
  </target>

This target is never used in a skin based site (they always have skinconf present from the seed).

Furthermore, since the core skinconf file no longer exists it breaks the dispatcher based sites, which may not have a skinconf.

----

There may well be other redundant code that needs to be cleared out.

Issue Links

• blocks: FOR-986 Dispatcher war fails to build if no skinconf.xml is in place
• is part of: FOR-809 Remove build targets around "skins"