Details
-
Bug
-
Status: Closed
-
Minor
-
Resolution: Fixed
-
0.8
-
None
-
Normal
Description
If we add a required plugin and provide a local directory to retrieve the plugin from, but fail to provide a plugin descriptor for that plugin Forrest cannot find, and therefore cannot install the plugin.
Having failed to deploy a required plugin Forrest should fail with an error, but it does not it continues to run. Even worse the output log gives no indication that a plugin was not correctly configured. It seems that our recent work on deploying plugins from local sources has broken the error checking for plugins.
Here is the relevant section from a problem run (this plugin is on in a local directory, but does not appear in any plugins.xml descriptor for that directory):
--------------------------------------------------------------
Installing plugin: org.saafe.forrest.plugin.input.osCommerce
--------------------------------------------------------------
check-plugin:
org.saafe.forrest.plugin.input.osCommerce is not available in the build dir. Try
ing to fetch it...
init-props:
echo-settings:
init-proxy:
fetch-plugins-descriptors:
fetch-plugin:
Trying to find the description of org.saafe.forrest.plugin.input.osCommerce in t
he different descriptor files
Using the descriptor file D:\projects\forrestPlugins\org.saafe.forrest.plugin.in
put.osCommerce\build\tmp\plugins-1.xml...
Processing D:\projects\forrestPlugins\org.saafe.forrest.plugin.input.osCommerce\
build\tmp\plugins-1.xml to D:\projects\forrestPlugins\org.saafe.forrest.plugin.i
nput.osCommerce\build\tmp\pluginlist2fetchbuild.xml
Loading stylesheet D:\openSource\forrest\main\var\pluginlist2fetch.xsl
findPlugin:
Using the descriptor file D:\projects\forrestPlugins\org.saafe.forrest.plugin.in
put.osCommerce\build\tmp\plugins-2.xml...
Processing D:\projects\forrestPlugins\org.saafe.forrest.plugin.input.osCommerce\
build\tmp\plugins-2.xml to D:\projects\forrestPlugins\org.saafe.forrest.plugin.i
nput.osCommerce\build\tmp\pluginlist2fetchbuild.xml
Loading stylesheet D:\openSource\forrest\main\var\pluginlist2fetch.xsl
findPlugin:
unpack-plugin:
install-plugin:
configure-plugin:
No locationmap provided for plugin org.saafe.forrest.plugin.input.osCommerce
Having failed to deploy a required plugin Forrest should fail with an error, but it does not it continues to run. Even worse the output log gives no indication that a plugin was not correctly configured. It seems that our recent work on deploying plugins from local sources has broken the error checking for plugins.
Here is the relevant section from a problem run (this plugin is on in a local directory, but does not appear in any plugins.xml descriptor for that directory):
--------------------------------------------------------------
Installing plugin: org.saafe.forrest.plugin.input.osCommerce
--------------------------------------------------------------
check-plugin:
org.saafe.forrest.plugin.input.osCommerce is not available in the build dir. Try
ing to fetch it...
init-props:
echo-settings:
init-proxy:
fetch-plugins-descriptors:
fetch-plugin:
Trying to find the description of org.saafe.forrest.plugin.input.osCommerce in t
he different descriptor files
Using the descriptor file D:\projects\forrestPlugins\org.saafe.forrest.plugin.in
put.osCommerce\build\tmp\plugins-1.xml...
Processing D:\projects\forrestPlugins\org.saafe.forrest.plugin.input.osCommerce\
build\tmp\plugins-1.xml to D:\projects\forrestPlugins\org.saafe.forrest.plugin.i
nput.osCommerce\build\tmp\pluginlist2fetchbuild.xml
Loading stylesheet D:\openSource\forrest\main\var\pluginlist2fetch.xsl
findPlugin:
Using the descriptor file D:\projects\forrestPlugins\org.saafe.forrest.plugin.in
put.osCommerce\build\tmp\plugins-2.xml...
Processing D:\projects\forrestPlugins\org.saafe.forrest.plugin.input.osCommerce\
build\tmp\plugins-2.xml to D:\projects\forrestPlugins\org.saafe.forrest.plugin.i
nput.osCommerce\build\tmp\pluginlist2fetchbuild.xml
Loading stylesheet D:\openSource\forrest\main\var\pluginlist2fetch.xsl
findPlugin:
unpack-plugin:
install-plugin:
configure-plugin:
No locationmap provided for plugin org.saafe.forrest.plugin.input.osCommerce