Details

      Description

      Plugins need to be able to provide default values for properties they require. This can be achieved by having
      org.apache.forrest.conf,ForrestConfModule load the relevant properties files after the project specific ones have been loaded and before the forrest defauits are loaded.

        Issue Links

          Activity

          Hide
          Ross Gardler added a comment -
          Plugins can now provide default settings in PLUGIN_HOME/default.plugin.properties.xml

          The values in these files can be overridden by a project in PROJECT_HOME/forrest.properties.xml

          However, the implementation is not yet complete and will break when we use plugins in-place or move their location from build/plugins because this location is hard wired into ForrestConfUtils (see Subversion commits on this issue).

          Furthermore, in order for this to work there must be a *duplicate* setting of requried.forrest.plugins in the projects forrest.properties.xml - that is a duplicate setting to that found in forrest.properties. This is because plugins are still loaded by consulting forrest.properties for the list of plugins but the default properties are loaded by examining the setting in forrest.properties.xml

          We therefore need to change the plugin loading mechanism so that it uses forrest.properties.xml
          Show
          Ross Gardler added a comment - Plugins can now provide default settings in PLUGIN_HOME/default.plugin.properties.xml The values in these files can be overridden by a project in PROJECT_HOME/forrest.properties.xml However, the implementation is not yet complete and will break when we use plugins in-place or move their location from build/plugins because this location is hard wired into ForrestConfUtils (see Subversion commits on this issue). Furthermore, in order for this to work there must be a *duplicate* setting of requried.forrest.plugins in the projects forrest.properties.xml - that is a duplicate setting to that found in forrest.properties. This is because plugins are still loaded by consulting forrest.properties for the list of plugins but the default properties are loaded by examining the setting in forrest.properties.xml We therefore need to change the plugin loading mechanism so that it uses forrest.properties.xml
          Hide
          Ross Gardler added a comment -
          There is no longer a need for duplicating the plugin list in forrest.properties.xml, it will fall back to using the forrest.properties list (note if it is defined in both then the xml one is given priority)
          Show
          Ross Gardler added a comment - There is no longer a need for duplicating the plugin list in forrest.properties.xml, it will fall back to using the forrest.properties list (note if it is defined in both then the xml one is given priority)

            People

            • Assignee:
              Ross Gardler
              Reporter:
              Ross Gardler
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development