Forrest
  1. Forrest
  2. FOR-432

excel plugin does only work for own documentation

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 0.7
    • Fix Version/s: 0.7
    • Labels:
      None
    • Environment:
      r149399 from 2005-02-01

      Description

      In input.xmap the path to table2document.xsl is set relative to the project. This works for the excel-plugin documentation but not for other projects.

        Activity

        Hide
        Johannes Schaefer added a comment -
        Changed the reference to
        <map:transform src="{forrest:plugins}/org.apache.forrest.plugin.excel/resources/stylesheets/table2document.xsl" />
        Moved the stylesheet to this directory.
        Added new feature: descriptive text.
        Fixed a minor issue (ss:Index).
        Cosmetic changes.
        See also changes.html
        Attached the whole plugin (zipped).
        Show
        Johannes Schaefer added a comment - Changed the reference to <map:transform src="{forrest:plugins}/org.apache.forrest.plugin.excel/resources/stylesheets/table2document.xsl" /> Moved the stylesheet to this directory. Added new feature: descriptive text. Fixed a minor issue (ss:Index). Cosmetic changes. See also changes.html Attached the whole plugin (zipped).
        Hide
        Ross Gardler added a comment -
        Thanks for spotting this and aking the improvements.

        Could you provide a patch (yes we can make one from the zip you provide if necessary, it's just I don't have the time right now).

        One note:

        <map:transform src="{forrest:plugins}/org.apache.forrest.plugin.excel/resources/stylesheets/table2document.xsl" />

        should be:

        <map:transform src="resources/stylesheets/table2document.xsl" />

        There is no longer any need to put the name of the plugin in the src, makes things a little easier if a plugin name gets changed. I think I changed the docs to reflect this but if not pleae let us know.
        Show
        Ross Gardler added a comment - Thanks for spotting this and aking the improvements. Could you provide a patch (yes we can make one from the zip you provide if necessary, it's just I don't have the time right now). One note: <map:transform src="{forrest:plugins}/org.apache.forrest.plugin.excel/resources/stylesheets/table2document.xsl" /> should be: <map:transform src="resources/stylesheets/table2document.xsl" /> There is no longer any need to put the name of the plugin in the src, makes things a little easier if a plugin name gets changed. I think I changed the docs to reflect this but if not pleae let us know.
        Hide
        Johannes Schaefer added a comment -
        I am not able to create a patch (see discussion on dev-list: http://marc.theaimsgroup.com/?l=forrest-dev&m=110785810429545&w=2).

        If someone puts in the zip file, I could provide a patch with enhanced functionality like images in cells, additional text as well as minor fixes.
        Show
        Johannes Schaefer added a comment - I am not able to create a patch (see discussion on dev-list: http://marc.theaimsgroup.com/?l=forrest-dev&m=110785810429545&w=2) . If someone puts in the zip file, I could provide a patch with enhanced functionality like images in cells, additional text as well as minor fixes.
        Hide
        Ross Gardler added a comment -
        Head has been pathed and the new version of the plugin has been deployed. Thanks.

        Please try and provide a patch in future, it is far easier to apply and so things will happen faster.
        Show
        Ross Gardler added a comment - Head has been pathed and the new version of the plugin has been deployed. Thanks. Please try and provide a patch in future, it is far easier to apply and so things will happen faster.
        Hide
        Johannes Schaefer added a comment -
        For revision 154656:

        The directory structure isn't correct:
        the resources folder is missing and table2document.xsl is still below the src tree, so the plugin doesn't work.
        Can anyone fix this, please?

        It also doesn't show up on 'forrest available-plugins'.
        Can anyone add it there, please?
        Show
        Johannes Schaefer added a comment - For revision 154656: The directory structure isn't correct: the resources folder is missing and table2document.xsl is still below the src tree, so the plugin doesn't work. Can anyone fix this, please? It also doesn't show up on 'forrest available-plugins'. Can anyone add it there, please?
        Hide
        Johannes Schaefer added a comment -
        building a patch still doesn't work,
        see http://issues.cocoondev.org/browse/FOR-441
        Show
        Johannes Schaefer added a comment - building a patch still doesn't work, see http://issues.cocoondev.org/browse/FOR-441
        Hide
        Ross Gardler added a comment -
        I clearly made some errors when applying your changes (this is easily done when there is no patch). I also forgot to add the resources folder I had created locally.

        I've added the resources folder now, but the samples pages are coming up blank. I'm afaid I don't have the time to fix this just yet so I've reopened the bug, I'm sure it is only a simple mistake though.
        Show
        Ross Gardler added a comment - I clearly made some errors when applying your changes (this is easily done when there is no patch). I also forgot to add the resources folder I had created locally. I've added the resources folder now, but the samples pages are coming up blank. I'm afaid I don't have the time to fix this just yet so I've reopened the bug, I'm sure it is only a simple mistake though.
        Hide
        Johannes Schaefer added a comment -
        This now seems to be fixed. Worked well for me: 'ant' in the excel plugin directory gives me a correctly rendered site below the build directory.

        Fro improvements on the functionality see the patch (!) at
          http://issues.cocoondev.org/browse/FOR-444
        Show
        Johannes Schaefer added a comment - This now seems to be fixed. Worked well for me: 'ant' in the excel plugin directory gives me a correctly rendered site below the build directory. Fro improvements on the functionality see the patch (!) at    http://issues.cocoondev.org/browse/FOR-444
        Hide
        Ross Gardler added a comment -
        I don't seem to be having much luck with this one - seems I made more silly mistakes. Still, at least it is working this time.

        (for those interested, the silly mistakes are forgetting to do a local-deploy after making changes)
        Show
        Ross Gardler added a comment - I don't seem to be having much luck with this one - seems I made more silly mistakes. Still, at least it is working this time. (for those interested, the silly mistakes are forgetting to do a local-deploy after making changes)

          People

          • Assignee:
            Ross Gardler
            Reporter:
            Johannes Schaefer
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development