Uploaded image for project: 'FOP'
  1. FOP
  2. FOP-3160

split packages within the FOP codebase

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • main
    • None

    Description

      whilst taking a look at modularising the project (see: FOP-3159) I found that that package names are duplicated across the maven sub-modules.

      For example, both fop-core and fop-utils have org.apache.fop.util.text.

       

      [ERROR] the unnamed module reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] the unnamed module reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] the unnamed module reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] the unnamed module reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module commons.logging reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module commons.logging reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module commons.logging reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] module commons.logging reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] module batik.awt.util reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module batik.awt.util reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module batik.awt.util reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] module batik.awt.util reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] module qdox reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module qdox reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module qdox reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] module qdox reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] module org.apache.commons.io reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module org.apache.commons.io reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module org.apache.commons.io reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] module org.apache.commons.io reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] module xmlgraphics.commons reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module xmlgraphics.commons reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module xmlgraphics.commons reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] module xmlgraphics.commons reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] module ant reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module ant reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module ant reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] module ant reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] module servlet.api reads package org.apache.fop.events from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module servlet.api reads package org.apache.fop.tools from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.events
[ERROR] module servlet.api reads package org.apache.fop.util from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util
[ERROR] module servlet.api reads package org.apache.fop.util.text from both org.apache.xmlgraphics.fop.core and org.apache.xmlgraphics.fop.util

      The project should be refactored a bit so that packages are not split across modules. This will be needed for JPMS

      Attachments

        Activity

          People

            ssteiner Simon Steiner
            singingbush Samael Bate
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: