[FOP-2869] [PATCH] basic-link to embedded file breaks with encryption

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Flags: Patch
• Assignee: Simon Steiner
• Reporter: Juan
• Created: 01/Jul/19 19:19
• Updated: 05/Jul/19 08:56
• Resolved: 05/Jul/19 08:56

Description

When processing a document with encryption and using with tag:

<fo:basic-link external-destination="embedded-file:some.pdf">The link to some file
</fo:basic-link>

The output pdf link doesn't work. 

The same input, without encryption works as expected.

About the Patch:

• This is related to FOP-916, applied the same fix but to PDFJavaScriptLaunchAction instead of PDFUri and extracted the common method into the parent class PDFAction.
• The extracted method implementation, is still very similar to 'encodeString' from PDFObject, just adds a 'getDocument() != null' condition (wich seems to be required for PDFActions)