[FOP-2858] [PATCH] FontUtil.guessStyle/guessWeight is passed java.awt.Font.getName() which can return localized name

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: 2.5, 2.2, 2.3, 2.4, 2.6
• Component/s: font/unqualified, renderer/awt
• Labels: patch windows
• Environment: Windows 10 Pro
• Flags: Patch, Important
• Assignee: Unassigned
• Reporter: Mikael Andersen
• Created: 12/Apr/19 12:24
• Updated: 25/Dec/21 07:35

Description

When InstalledFontCollection enumerates OS provided Fonts, the style/weight is guessed from java.awt.Font.getName();

Originally it was Font.getFontName() method, which FOP-1452 fixed to getName(). As written in description of FOP-1452:

Attaching patch which uses
Font.getName(), tested on Windows XP. Another possibility would be to use
Font.getFontName(Locale.ENGLISH).

 The latter option is exactly what I think it should be changed to, as I now experience on my Windows 10 box (all in house experiences same), that Font.getName() will return localized texts for style/weight, for most fonts, when user.language=da.

The attached patch only targets passing proper name to FontUtil.guessXXX methods, which are vital for proper rendering of preview and printing (ps) for these fonts.

However Java2DGraphicsState.updateFont(...) is also subject to bug, as Font.getFontName() is used,

{{ boolean updateName = (!mapper.getFontName().equals(}}
{{ getGraph().getFont().getFontName()));}}

 

effectively comparing Font.getName() with Font.getFontName() which will not always match.