Uploaded image for project: 'FOP'
  1. FOP
  2. FOP-2536

[PATCH] Varying table border thickness in PDF output

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.6
    • renderer/pdf
    • None

    Description

      As already pointed out in a comment to the original issue, this is a problem with the PDF viewers. FOP generates the borders correctly. The viewers render border segments correctly when they are rectangles, but they make mistakes when the segments are more general polygons. In my patch, I am splitting the polygons into rectangles, covering as much of the polygon as possible, write the rectangles to the PDF, then write the remaining triangles.

      Attachments

        1. extended-patch-FOP-2536.patch
          66 kB
          Jan Tošovský
        2. extended-patch-FOP-2536-new.patch
          67 kB
          Jan Tošovský
        3. fop-2434-alternative.patch
          17 kB
          Matthias Reischenbacher
        4. patch-FOP-2434.diff
          38 kB
          Martin Leitner
        5. Polygon.java
          13 kB
          Martin Leitner
        6. table-border.fo
          13 kB
          Jan Tošovský
        7. table-border-overpaint.pdf
          7 kB
          Jan Tošovský
        8. tableBorders_fop_2.0.pdf
          6 kB
          Martin Leitner
        9. tableBorders_fop_2.1_AdobeReader_11.png
          28 kB
          Martin Leitner
        10. tableBorders_fop_2.1.pdf
          6 kB
          Martin Leitner
        11. tableBorders_patched.pdf
          5 kB
          Martin Leitner
        12. tableBorders.fo
          4 kB
          Martin Leitner
        13. table-border-standard.pdf
          6 kB
          Jan Tošovský

        Issue Links

        supercedes

        Bug - A problem which impairs or prevents the functions of the product. FOP-2434 Varying table border thickness in PDF output

        • Major - Major loss of function.
        • Resolved
        links to

        Web Link GitHub Pull Request #4

        Activity
          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ssteiner Simon Steiner
            martin.leitner@infinica.com Martin Leitner
            Votes:
            2 Vote for this issue
            Watchers:
            8 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment